f-koehler
[Feature Request] Config to show tags on Peers Page
I use tags to identify different portions of my tailnet and would greatly appreciate the ability to see the tags of each peer on the peer list page.
@williamhatcher, thanks for the suggestion! I think it makes a lot of sense, even though I have not used tags extensively so far.
I will have to give it some thought on how to integrate. I am currently working on uncluttering the peer list page (the entries now fit in a single row). Since this suggestion is somewhat diametral to that, I am leaning towards making it an optional feature which can be enabled in the settings.
If you organize you tailnet this way, you probably would also be looking for a functionality to filter by this tag, right?
I absolutely think it should be an optional setting. I hadn’t considered filtering by them but yes.
Could you add some documentation on setting up a development environment? I would have tried to add tags myself but I wasn’t sure on how to start building my Qt changes. (it has been a long time since I’ve done Qt).
-- Grace and Peace, William Hatcher, System Engineer, iSTAR Lab
From: Fabian Koehler @.> Sent: Wednesday, March 5, 2025 9:07:47 PM To: f-koehler/KTailctl @.> Cc: William Hatcher @.>; Mention @.> Subject: Re: [f-koehler/KTailctl] [Feature Request] Config to show tags on Peers Page (Issue #376)
@williamhatcherhttps://github.com/williamhatcher, thanks for the suggestion! I think it makes a lot of sense, even though I have not used tags extensively so far.
I will have to give it some thought on how to integrate. I am currently working on uncluttering the peer list page (the entries now fit in a single row). Since this suggestion is somewhat diametral to that, I am leaning towards making it an optional feature which can be enabled in the settings.
If you organize you tailnet this way, you probably would also be looking for a functionality to filter by this tag, right?
— Reply to this email directly, view it on GitHubhttps://github.com/f-koehler/KTailctl/issues/376#issuecomment-2702674823, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AF3WBO5EVHSOBFLSEK7ZSML2S63YHAVCNFSM6AAAAABYEMWIUKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMBSGY3TIOBSGM. You are receiving this because you were mentioned.Message ID: @.***>
[f-koehler]f-koehler left a comment (f-koehler/KTailctl#376)https://github.com/f-koehler/KTailctl/issues/376#issuecomment-2702674823
@williamhatcherhttps://github.com/williamhatcher, thanks for the suggestion! I think it makes a lot of sense, even though I have not used tags extensively so far.
I will have to give it some thought on how to integrate. I am currently working on uncluttering the peer list page (the entries now fit in a single row). Since this suggestion is somewhat diametral to that, I am leaning towards making it an optional feature which can be enabled in the settings.
If you organize you tailnet this way, you probably would also be looking for a functionality to filter by this tag, right?
— Reply to this email directly, view it on GitHubhttps://github.com/f-koehler/KTailctl/issues/376#issuecomment-2702674823, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AF3WBO5EVHSOBFLSEK7ZSML2S63YHAVCNFSM6AAAAABYEMWIUKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMBSGY3TIOBSGM. You are receiving this because you were mentioned.Message ID: @.***>
I absolutely think it should be an optional setting. I hadn’t considered filtering by them but yes.
Could you add some documentation on setting up a development environment? I would have tried to add tags myself but I wasn’t sure on how to start building my Qt changes. (it has been a long time since I’ve done Qt). …
I think this should be tackled in two parts:
- Show tags in peer list:
- Add a configuration option for
KConfig - Add a toggle in the settings page
- Show the tags in case the option is enabled (e.g. in a second row?)
- Add a configuration option for
- Add a filter. This is probably quite tricky.
If you really want to work on this I would focus at the first part. The second part will require a lot of considerations.
I will try to add some documentation on how to setup a development environment. What distribution are you using?
I am mainly using nix for the development environment. But it should not be too hard to do it on other distros
Implemented the first part (optionally display the tags in the peer list). Filtering will come in a follow-up PR.
@williamhatcher there are now some instructions on how to do local development using either Fedora or NixOS: https://github.com/f-koehler/KTailctl?tab=readme-ov-file#development (in case you want to contribute in the future).