ezpublish-legacy icon indicating copy to clipboard operation
ezpublish-legacy copied to clipboard

eZDFS: don't throw exception with empty string as path

Open joaoinacio opened this issue 11 years ago • 12 comments

JIRA: https://jira.ez.no/browse/EZP-23409

If a path does not exist in in eZDFSFileHandlerDFSBackend, do not pass an empty string (realpath) to thrown exception.

joaoinacio avatar May 15 '13 14:05 joaoinacio

Please pay attention to commit messages. The part that appears in logs isn't significant enough.

+1 apart from that.

bdunogier avatar May 15 '13 15:05 bdunogier

commit message updated

joaoinacio avatar Jun 17 '13 20:06 joaoinacio

Squashed, rebased, added JIRA issue. gentle ping @andrerom

joaoinacio avatar Sep 30 '14 10:09 joaoinacio

+1

andrerom avatar Sep 30 '14 18:09 andrerom

Do we want to merge this ? Given that master will never be released officially...

bdunogier avatar Jan 06 '15 19:01 bdunogier

Please don't give up on the legacy users who might need improvements now and in the future. It is painful to hear comments like, "Do we want to merge this ? Given that master will never be released officially...".

brookinsconsulting avatar Jan 20 '15 04:01 brookinsconsulting

Well, we know that we (eZ) will not release another major version of ezpublish legacy. It doesn't affect maintenance ones, of course.

bdunogier avatar Jan 20 '15 07:01 bdunogier

@bdunogier my +1 still stands, do you have any concerns for regressions given you know these parts the best?

andrerom avatar Jan 20 '15 15:01 andrerom

Hmmm... I guess not. I'm not -1 :-)

bdunogier avatar Jan 27 '15 13:01 bdunogier

@bdunogier lets maybe turn the question around, is this something we should backport? hence which should defiantly go into master first :)

andrerom avatar Jan 28 '15 08:01 andrerom

I don't think it adds any risk, and it could improve experience. I'm not against a backport.

If we don't backport it, there is no point in merging it, is there ? :-)

bdunogier avatar Jan 29 '15 12:01 bdunogier

well, it could still be part of a 2015.01.0x or potential future tag of course.

andrerom avatar Jan 29 '15 12:01 andrerom