ezpublish-legacy
ezpublish-legacy copied to clipboard
eZDFS: don't throw exception with empty string as path
JIRA: https://jira.ez.no/browse/EZP-23409
If a path does not exist in in eZDFSFileHandlerDFSBackend, do not pass an empty string (realpath) to thrown exception.
Please pay attention to commit messages. The part that appears in logs isn't significant enough.
+1 apart from that.
commit message updated
Squashed, rebased, added JIRA issue. gentle ping @andrerom
+1
Do we want to merge this ? Given that master will never be released officially...
Please don't give up on the legacy users who might need improvements now and in the future. It is painful to hear comments like, "Do we want to merge this ? Given that master will never be released officially...".
Well, we know that we (eZ) will not release another major version of ezpublish legacy. It doesn't affect maintenance ones, of course.
@bdunogier my +1 still stands, do you have any concerns for regressions given you know these parts the best?
Hmmm... I guess not. I'm not -1 :-)
@bdunogier lets maybe turn the question around, is this something we should backport? hence which should defiantly go into master first :)
I don't think it adds any risk, and it could improve experience. I'm not against a backport.
If we don't backport it, there is no point in merging it, is there ? :-)
well, it could still be part of a 2015.01.0x or potential future tag of course.