ezpublish-legacy
ezpublish-legacy copied to clipboard
Fix EZP-24137: alone character "0" inside xml custom and native tag replaced by space
This is a strange case, but this kind of thing append.
I tried to create a Jira ticket but I didn't have account.
Hello @yannschepens
You need to register for a 'free' account first. Please register here: https://login.ez.no/register?return=http://share.ez.no/
Then when you have your account created (and verified? I forget if they still do that, in any case) next you can login to jira.ez.no using the same user name and password and create an issue ticket.
Then share the url to the issue ticket here in this PR. Also rename your PR Title to include the issue ticket number (Follow the standard format for this).
Thank you. I hope this helps!
Cheers, Brookins Consulting
+1 with nitpicks and issues once someone is able to create one.
@brookinsconsulting Seems to be some issues on share.ez.no, so probably not possible to register right now :(
@andrerom OK. Since I can not see into those share issues myself would you be so kind to update this PR with a comment when you think those 'issues' with registration / share are resolved?
Updated ;)
@yannschepens
Your improvements are good but ... you did not fix the CS issues that @andrerom is requiring you make first.
Once you fix the CS issues, please remember to rebase and flatten your commits into one commit (Like you have done in the past / already before).
Thank you for your continued support!
Cheers, Brookins Consulting
Seems to be fixed now.
review ping @yannickroger @bdunogier (I think this is good for 5.3 and 5.4 backport as well)