ezpublish-legacy icon indicating copy to clipboard operation
ezpublish-legacy copied to clipboard

Fix EZP-23911: ezwordtoimageoperator with $size[0] not set

Open Adcaelo opened this issue 10 years ago • 8 comments

using php "reset" function to retrieve first element of $sizes array because $sizes[0] is not always set

ex. in ezpublish_legacy/share/icons/crystal-admin/icon.ini

[IconSettings]
# Defined sizes, each size refers to the name of the subdirectory
# of the icon theme. If the name contains two numbers with an
# x in between it will be considered to be the width and height
# of the icon, if not no size is will be given
Sizes[]
Sizes[normal]=32x32
Sizes[small]=16x16_indexed
Sizes[ghost]=16x16_ghost
Sizes[original]=16x16_original

see. Jira EZP-23911 https://jira.ez.no/browse/EZP-23911

Adcaelo avatar Jan 19 '15 09:01 Adcaelo

@Adcaelo Thanks for your pull request. Can you create a Jira issue on http://jira.ez.no describing the problem (copy pasting the description of your PR) so we can track your patch.

yannickroger avatar Jan 19 '15 09:01 yannickroger

+1 with Jira issue

lolautruche avatar Jan 19 '15 10:01 lolautruche

+1

yannickroger avatar Jan 19 '15 10:01 yannickroger

@Adcaelo once your issue is created:

  • Add the link in the description of your pull request
  • Rename your commit to add the issues number and use our standard commit template Fix EZP-42: ewwordtoimageoperator with $size[0] not set
  • Add a comment to ping us.

If you need help renaming your commit (or anything else), feel free to ask.

yannickroger avatar Jan 19 '15 10:01 yannickroger

done : https://jira.ez.no/browse/EZP-23911

Adcaelo avatar Jan 19 '15 10:01 Adcaelo

@Adcaelo you just have to rename the commit (same title as the PR), and I can merge it ;)

git commit --amend
git push fork patch-1 --force

yannickroger avatar Jan 19 '15 10:01 yannickroger

Gotta wait to be home, limited network access here. I've only access to Github web interface !

Adcaelo avatar Jan 19 '15 10:01 Adcaelo

@Adcaelo pushes also work with HTTP :wink:

lolautruche avatar Jan 19 '15 13:01 lolautruche