ezplatform-http-cache icon indicating copy to clipboard operation
ezplatform-http-cache copied to clipboard

Deprecate ez_http_tag_location

Open adriendupuis opened this issue 4 years ago • 7 comments

Question Answer
JIRA issue N/A
Type Improvement/Misc
Target version master
BC breaks no
Doc needed https://github.com/ezsystems/developer-documentation/pull/1297

Mark ez_http_tag_location as deprecated and ez_http_cache_tag_location as its alternative. If 2.5 BC is “to be cleaned up”, one should be informed to not using this and replace it.

TODO:

  • [x] Implement feature / fix a bug.
  • [ ] Implement tests + specs and passing ($ composer test)
  • [x] Fix new code according to Coding Standards ($ composer fix-cs).
  • [x] Ask for Code Review.

adriendupuis avatar Jan 29 '21 14:01 adriendupuis

@lserwatka So, this will be deprecated in 4.0 then (and possibly removed in 5.0) ?

vidarl avatar Feb 09 '21 08:02 vidarl

This is already deprecated, we need to add a note in 3.3 and remove it in 4.0 as discussed offline.

lserwatka avatar Feb 09 '21 10:02 lserwatka

@adriendupuis CI is reporting that code style needs to be fixed here. Could you please run composer fix-cs command, and then commit and push it's result? Thank you in advance,

adamwojs avatar Feb 10 '21 21:02 adamwojs

Dear gentlemen, when exactly were the two functions deprecated? I mean ez_http_tag_relation_ids() and ez_http_tag_relation_location_ids() Was it starting from 3.0 or 3.3?

dabrt avatar Feb 11 '21 11:02 dabrt

Communication wise, these were deprecated in 3.3.0 Technically, they will be deprecated in 3.3.2 ( if this PR gets merged by then )

vidarl avatar Feb 11 '21 11:02 vidarl

@adamwojs : ready for merge, right?

vidarl avatar Mar 05 '21 10:03 vidarl

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Jul 01 '21 07:07 sonarqubecloud[bot]