ezplatform-admin-ui icon indicating copy to clipboard operation
ezplatform-admin-ui copied to clipboard

IBX-7983: Handled previewing `ezimage` field with height of 0

Open barw4 opened this issue 11 months ago • 2 comments

Question Answer
Tickets IBX-7983
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Division by 0 is impossible, hence, the change.

.avif files in later PHP versions should be handled properly by the getimagesize method (since PHP 8.1 RC3), but we still have to handle older files somehow (dimension values are stored in .xmls in a database).

Checklist:

  • [x] Coding standards ($ composer fix-cs)
  • [x] Ready for Code Review

barw4 avatar Mar 26 '24 14:03 barw4

@konradoboza I don't think there is a need as those are already parsed as strings https://github.com/ezsystems/ezplatform-kernel/blob/1.3/eZ/Publish/Core/Persistence/Legacy/Content/FieldValue/Converter/ImageConverter.php#L115

barw4 avatar Mar 27 '24 09:03 barw4