ezplatform-admin-ui icon indicating copy to clipboard operation
ezplatform-admin-ui copied to clipboard

Published 20 hours ago • verified publisher icon ezsystems

IBX-1948: Log exceptions from admin-ui

Open vidarl opened this issue 3 years ago • 6 comments

Question Answer
Tickets https://issues.ibexa.co/browse/IBX-1948
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes/no
Doc needed? no
License GPL-2.0

Note when merging : I think [log level](https://github.com/ezsystems/ezplatform-admin-ui/blob#### Checklist:

  • [x] Coding standards ($ composer fix-cs)
  • [x] Ready for Code Review

vidarl avatar Jan 18 '22 07:01 vidarl

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Jan 18 '22 07:01 sonarqubecloud[bot]

@vidarl could you please address @Steveb-p feedback ?

adamwojs avatar Apr 22 '22 08:04 adamwojs

Hi @adamwojs . Yes, sorry about the delay. I'll have a look next week

vidarl avatar Apr 22 '22 08:04 vidarl

@vidarl could you please address @Steveb-p feedback ?

@adamwojs , I have done so, but I have some comments. Please see the unresolved threads.

vidarl avatar Apr 28 '22 09:04 vidarl

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar May 19 '22 12:05 sonarqubecloud[bot]

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Jul 06 '22 11:07 sonarqubecloud[bot]

Hi, How do I get this commit into my DXP build? I really need the admin UI to log errors becuase it's very difficult to troubleshoot. Please review this commit and if passed/ merge.

davidsayre avatar Dec 15 '22 16:12 davidsayre

Hi, How do I get this commit into my DXP build? I really need the admin UI to log errors becuase it's very difficult to troubleshoot. Please review this commit and if passed/ merge.

@davidsayre Sorry, it kinda went under the radar.

As a workaround, you can create a service in your project, and make it listen to kernel.exception events, with priority higher than this listener (which is currently 0 priority, so at minimum 1). Then follow normal Symfony rules for injecting logger and log the error in the same fashion as is done here.

Steveb-p avatar Dec 15 '22 17:12 Steveb-p

Everything is resolved. Ready for merge now ? @Steveb-p

vidarl avatar Jan 11 '23 14:01 vidarl

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

sonarqubecloud[bot] avatar Jan 12 '23 09:01 sonarqubecloud[bot]