ezfind icon indicating copy to clipboard operation
ezfind copied to clipboard

eZ Find suggestion

Open xrow opened this issue 11 years ago • 14 comments

xrow avatar Nov 21 '14 03:11 xrow

Hi and thanks @xrow

Can you please create an issue on Jira and describe what you're contributing?

Ping @andrerom @paulborgermans @bdunogier @yannickroger

lolautruche avatar Nov 21 '14 09:11 lolautruche

Here you go

https://jira.ez.no/browse/EZP-23674 https://jira.ez.no/browse/EZP-23675

xrow avatar Nov 21 '14 09:11 xrow

ping @paulborgermans

andrerom avatar Nov 21 '14 11:11 andrerom

-1: for loc field type, there is no schema.xml counterpart (otherwise would be ok) locale conversion should be done before its submitted to the ezfind api

paulborgermans avatar Nov 21 '14 20:11 paulborgermans

2,5 is a valid php float. Conversion needs to happen exactly there. PHP isn't like other languages unfortunatelly. http://php.net/manual/de/language.types.float.php#58824 I try to attach the schema.

xrow avatar Nov 22 '14 20:11 xrow

  • location type feature: schema still wrong
  • formatting and locales: when using a non default (C) locale, other numeric output (int, maybe custom datatypes) will also cause problems, so patch is anyhow incomplete

paulborgermans avatar Nov 27 '14 16:11 paulborgermans

I see your point with the locale. Unfortuatelly this means somewhere in the installation setlocale isn`t properly used. I investigate on that one. Can you point out what is wrong with the schema?

xrow avatar Nov 27 '14 16:11 xrow

On having more robustness towards any other locale, see this gist: https://gist.github.com/paulborgermans/0d10f4d99f3fb0a7a3c8

location in schema on the other hand: 4 underscores instead of 3 in the new dynamic fields added, and also the fieldtype for location is missing

hth Paul

paulborgermans avatar Nov 27 '14 22:11 paulborgermans

@xrow Issue closed as you requested, can you close this pull request ?

yannickroger avatar Nov 28 '14 08:11 yannickroger

The pull request yet has this feature, but I can live without it since we patch the sources anyway. Up to you.

xrow avatar Nov 28 '14 09:11 xrow

Hi,

implementing a different naming for the dynamic field is too much work on our end. Lets forget the feature request and lets close the pull. In addition I would very much prefer the patch (https://gist.github.com/paulborgermans/0d10f4d99f3fb0a7a3c8 ) that @paulborgermans is proposing, but I would need it in 5.4 branch.

xrow avatar Nov 28 '14 09:11 xrow

ping @andrerom regarding @paulborgermans patch

yannickroger avatar Nov 28 '14 09:11 yannickroger

@yannickroger

HTTP/1.1 501 Not Implemented
Date: Sun, 30 Nov 2014 21:07:25 CET
Connection: close

andrerom avatar Nov 30 '14 20:11 andrerom

so should we close this PR ?

yannickroger avatar Dec 01 '14 14:12 yannickroger