gitlabber icon indicating copy to clipboard operation
gitlabber copied to clipboard

Clone/pull by a group id

Open konfetka1989 opened this issue 3 years ago • 4 comments

If you have access to a large amount of groups, it may take much time to load an entire tree. It would be nice to have an opportunity to specify an exact group id which you want to clone.

I propose my solution: https://github.com/konfetka1989/gitlabber/commit/e48c267c351ea7e591d4d502e52ec123563eea03

Please consider it. Thanks.

I didn't create a pull request, because CONTRIBUTING.md states I have to discuss my changes with the owner first.

konfetka1989 avatar Aug 04 '21 18:08 konfetka1989

thanks for submitting code and suggesting this feature, I do realize for large setups reading the entire tree structure can take a long time and incur a lot of API calls.

2 concerns we need to address with this feature:

  1. I am assuming it plays well with globre patterns (if a user specifies a globre pattern that doesn't match with the selected group it will result in an empty tree but that is to be expected I guess)
  2. You chose to use group id for root filtering but for the majority of gitlabber usage people get accustomed to use project and group names/paths. Should this be considered in the root filtering feature? looking forward this may translate into more issues being opened for this.

ezbz avatar Aug 27 '21 16:08 ezbz

Hi @ezbz

Thank you for the feedback! Now I see several issues with my approach. I think I need to revisit this feature.

konfetka1989 avatar Aug 27 '21 20:08 konfetka1989

Hi @ezbz

I created a draft pull request which provides a new approach to using some group as a root: https://github.com/ezbz/gitlabber/pull/89

Could you please review it? Thank you.

konfetka1989 avatar Sep 24 '21 19:09 konfetka1989

Hi everybody! It will be very helpful for me as unfortunately I am hitting gitlab rate limits, so - sadly - I cannot use this tool. AFAIU this merge request should limit the number of http requests.

radoslav006 avatar Jan 26 '22 14:01 radoslav006