eza icon indicating copy to clipboard operation
eza copied to clipboard

feat!: support env EZA_QUOTING_STYLE, replace --no-quotes with --quotes=always,auto,never

Open PThorpe92 opened this issue 2 years ago • 4 comments

#584

Got me thinking about the different quoting styles that LS supports, and I think it's reasonable to offer some of this. Also, I am not a fan of the --no-x flags. I think it makes much more sense to offer an ENV var solution for NEVER and default it to auto and then offer a way to pass it in the command line. Idk who would want all their filenames quoted but hey, it's an option for LS.

It would obviously remain defaulted to auto, so the only thing that would break would be the --no-quotes flag would have to either be --quotes=never or the EZA_QUOTING_STYLE=never would have to be set.

Also: for anyone testing this, we are still waiting on #569 to get merged to fix the width/spacing issue

PThorpe92 avatar Oct 31 '23 16:10 PThorpe92

EDIT: should be all set now

PThorpe92 avatar Oct 31 '23 16:10 PThorpe92

It would obviously remain defaulted to auto, so the only thing that would break would be the --no-quotes flag would have to either be --quotes=never or the EZA_QUOTING_STYLE=never would have to be set.

I mean, right now I do kinda feel comfortable with just saying goodbye to the --no-quotes flag, but post-clap post-1.0 we'd probably not do this, and have --no-quotes equivalent to --quotes=never.

cafkafk avatar Nov 03 '23 17:11 cafkafk

SO, I tried to fix the conflicts here (sorry for necrobumping but I thought it would be fun to try and clear out a bit of backlog). Did we ever talk about perhaps keeping around a backward compat --no-quotes flag? We could hide it from the user (not put in readme etc), but just make it behave like --quotes=never to avoid making this a breaking change

cafkafk avatar Dec 28 '24 18:12 cafkafk

I honestly don't remember if we did. Seems like a reasonable thing to do tho, just to avoid breaking anything

PThorpe92 avatar Dec 28 '24 20:12 PThorpe92