eza-community
feat: add --spacing parameter
This adds a --spacing parameter to the cli. This is related to #520.
Initially I thought of adding the parameter as --space-between-columns, but the name seemed to be too long to be typed all the time.
Simple
Before:
After:
Long
Before:
After:
Hi, thanks for your contribution. This is indeed a great idea and a really useful one to clarify output. I made some comments feel free to discuss them if you want. I will add two more general ones, first if you could cleanup the commit history so that we can understand more what happenned. I dont think you need to squash everything into one but maybe separate into the different parties. Also for the tests, the one you wrote yourself need to have a stdout and stderr file I believe (please tell me if I am wrong). And you will need to generate and update the powertest, for this I would recommend installing eza-community/powertest and using our Justfile. If you have any questions or need help feel free to ask
@MartinFillon I made a few changes based on your comments. How does it look now? Rust is def not my strongest suit, so in case something is not right, let me know. :)
Edit: rewrote the whole commit history for a better understanding
Thats some great work you did there. I dont have any complaints based on the code. Now as I said you still need to update the ptests. If you need help on how to as my previous comment might not be the best I can provide some. You will also need to sort out the CI not passing, I would recommend for that to use nix but if you have trouble please ask for help !
@MartinFillon
I'm having several issues trying to run nix locally on macOS, especially when running just itest.
sudo and fd is not working, even if I install it using nativeBuildInputs.
Unfortunately, I don't have time to keep debugging this. Could you help me with that?