eza-community
1.upgrade rust to 1.85.0. 2. add wildmatch to the path
The wildmatch thing looks interesting, thanks, but could you please explain how this exactly improves things, is it about performance or about behavior and a specific example where it improves it. Also a short performance comparison with hyperfine would be nice.
About the MSRV change: The reason we are trailing Rust stable by several versions as many other projects like bat do as well, is that not all systems can install the latest rust version via rustup for example and thus would not be able to build eza if we would use the latest version. Also, I saw you opened a similar PR for bat: sharkdp/bat#3216 . So while I would lean towards no, we are not upgrading the MSRV to 1.85 now, I would also like to hear first what the bat team has to say about this.
Last but not least, while this PR should actually be two PRs, it should at least split the different things (wildmatch and msrv) into separate commits that also follow conventional commit format.
I want to do like that : eza -l E:\workspace* and show the folder like E:\workspace_node ,E:\workspace_java ,E:\workspace_rust ....
I was planning on proposing using wild with clap after we merge #1447. I didn’t study the problem so I’m not sure about the pro/cons of each solutions.
I want to do like that : eza -l E:\workspace* and show the folder like E:\workspace_node ,E:\workspace_java ,E:\workspace_rust ....
If I run eza -l Do* in my home folder, it lists files from Documents and Downloads, so what exactly does this add to that functionality?
I would also strongly suggest to split this into two PRs, one for the wildcard matching and one for the MSRV change.
If I run
eza -l Do*in my home folder, it lists files fromDocumentsandDownloads, so what exactly does this add to that functionality?
IIRC it’s to add the feature on Windows, glob is not supported by the shell and should be handled by the app.
IIRC it’s to add the feature on Windows, glob is not supported by the shell and should be handled by the app.
Ah, thanks for the hint, my mistake :)
About the MSRV change: The reason we are trailing Rust stable by several versions as many other projects like bat do as well, is that not all systems can install the latest rust version via rustup for example and thus would not be able to build eza if we would use the latest version. Also, I saw you opened a similar PR for bat: sharkdp/bat#3216 . So while I would lean towards no, we are not upgrading the MSRV to 1.85 now, I would also like to hear first what the bat team has to say about this.
So, about the MSRV change ... the bat team now added a comment to their Cargo.toml stating that the MSRV can be bumped if there is a particular reason for it: https://github.com/sharkdp/bat/pull/3260/files ... So I would also like to know if there is a particular reason?