eznode

eznode copied to clipboard

shesek

Add additional Containerfile/Dockerfile based on alpine

2

The Dockerfile used is based on debian, it would be helpful to have another one that is based on alpine.

emanuelb

Insecure /tmp usage with static path (use mktemp instead or not shared /tmp)

2

Files / Folders are used in /tmp with static/predictable names, which is bad practice and in general as it's vulnerable to malicious usage from other users on the system (it's...

emanuelb

Use /bin/sh instead of /bin/bash if possible in scripts

1

There are many scripts in repo that use `#!/bin/bash` for some of them it's possible to use `#!/bin/sh` instead without other modifications, for example like in `./eznode/tor/install` `./eznode/tor/bin/tor-newnym` it might...

emanuelb

Mention podman & rootless containers

4

Podman is alternative to docker, it's already pre-installed in fedora & other related os, thus can you mention it as alternative (after testing it's working) aka the only dependency is...

emanuelb

Using existing node automatically

2

Idea mentioned in https://github.com/janoside/btc-rpc-explorer/pull/279#issuecomment-808699687 **TL;DR: scroll down to "The simplest client-side implementation..."** Currently I solve this in my repository by simply placing proper configuration files in standard location and then...

Kixunil