Eugene Yurtsev

Results 480 comments of Eugene Yurtsev

Closing due to lack of activity.

@rlancemartin looking great, left suggestions to rename a few things. I want to propose something radical -- let's take out all file I/O for the first iteration, so there's no...

@rlancemartin left a few comments for minor changes, we're looking pretty good -- let me know if makes sense -- should be able to implement and then re-lint and we...

Thank you for the contribution @mrtj ! Code is looking great! One request is if you could move the test from integration to unit test. Follow these guidelines -- https://github.com/hwchase17/langchain/blob/master/.github/CONTRIBUTING.md#working-with-optional-dependencies...

@hwchase17 -- Proposal seems to add an abstract method to add a custom message which seems reasonable to me -- it looks like a more appropriate method for the base...

@dev2049 this rename looks great to me! And it's backwards compatible soooo :)

@dev2049 we need to re-run tests on this, i'm a bit confused about what happened to the test runner. Concerned that there might be some test that relies on having...

This looks good to me, but would appreciate :eye: since it's a core prompt