Trade-Dangerous icon indicating copy to clipboard operation
Trade-Dangerous copied to clipboard

max-link-ly attribute review

Open kfsone opened this issue 2 months ago • 0 comments

What happened?

Per #263 for most commands that take both a --ly type argument and a --max-link-ly argument there's logic that says:

max_ly = cmdenv.maxLy or cmdenv.maxLinkLy

this truthiness test means that you can't say "--ly 0" to mean "in-system only", unlike the local cmd which uses:

max_ly = cmdenv.ly if cmdenv.ly is not None else cmdenv.maxLinkLy

allowing you to specify a 0-ly range.

Notably, the local command gives the parameter a slightly different name to others. But we should probably evaluate whether the truthiness test is good or if we want to be able to use in-system-only commands more easily.

Reproduction steps

n/a

Backend

SQLite

Logs / output

n/a

Environment

No response

kfsone avatar Jan 03 '26 06:01 kfsone