Jure Varlec

Results 55 comments of Jure Varlec

Opening raw videos even without *.qarv files is implemented in e796eabf5ced2164e36fcc8adbf7c67d02328008. Hotkeys are still TODO.

Personally, I never used OSX, and I have no experience with XCode toolchain. How did you install Aravis? Apparently, `pkg_config` can't find it. Or anything else, for that matter. @shrx...

I've simplified things a bit since yesterday, and did a smoke test with areaDetector. I noticed that its plugins already have working destructors, so I just forced the NDPosPlugin to...

I've rebased, wrote the documentation, and extended the example driver. While writing the docs, I noticed that `asynManager::lockPort` doesn't go through the request queue as I had thought. Now, `lockPort`...

> Rather than having every driver create an exiting_ flag and set it in the destructor, would it be nicer to provide an asynManager method pasynManager->isExiting(), and/or an asynPortDriver method...

Sure, I can add some background. But why open an issue? This stuff belongs to the cover letter of the PR, no? Especially the goals and limitations.

In other words, the "problems" go into the issue, and the "goals" and "limitations" go into the description above. Clear enough. The reason I asked is that, personally, I have...

@ericonr Thank you very much for the review!

> eg. In lockPort(), the defunct flag is tested before any locking. > Maybe it should be tested after locking synchronousLock? You're right, will fix. > eg. The added doc....

I've thought about how to make things more straightforward for users, and decided that it is simpler to just forbid deleting a destructible driver without calling `shutdown()` first. If the...