Macaw icon indicating copy to clipboard operation
Macaw copied to clipboard

SWXMLHash 6.0.0 Compatibility

Open jminutaglio opened this issue 3 years ago • 4 comments

SWXMLHash 6.0.0 renames the main class from SWXMLHash to XMLHash.

This impacts Macaw in SVGParser -> parse()

changing to (lines 135-150) resolves:

    fileprivate func parse() throws -> Group {
        let config = XMLHash.config { config in
            config.shouldProcessNamespaces = true
        }
        let parsedXml = config.parse(xmlString)

        var svgElement: XMLHash.XMLElement?
        for child in parsedXml.children {
            if let element = child.element {
                if element.name == "svg" {
                    svgElement = element
                    try prepareSvg(child.children)
                    break
                }
            }
        }

jminutaglio avatar Sep 29 '21 13:09 jminutaglio

The same happens to me

NeedNap avatar Sep 30 '21 13:09 NeedNap

SWXMLHash version should be locked in podspec file until 6.0.0 is supported.

silvansky avatar Oct 01 '21 18:10 silvansky

Facing the same issue.

razon30 avatar Oct 02 '21 13:10 razon30

Same issue here

MaxenceMax avatar Oct 06 '21 13:10 MaxenceMax