gitui icon indicating copy to clipboard operation
gitui copied to clipboard

Feature #875: Delete referring branches

Open alessandroasm opened this issue 4 years ago • 5 comments

This Pull Request fixes/closes #875.

It changes the following:

  • After deleting a branch, check if there are any upstream / tracking branches and ask if user wants to delete them as well.

I followed the checklist:

  • [x] I added unittests
  • [x] I ran make check without errors
  • [x] I tested the overall application
  • [x] I added an appropriate item to the changelog

alessandroasm avatar Oct 10 '21 13:10 alessandroasm

Hello @extrawurst, thanks for the quick review and suggestions. I've just updated the PR with the following:

  • Reverted the refactoring and added the annotation to disable clippy::too_many_lines error
  • Added some assertions for get_branch_trackers in the existing unittests
  • Fixed the string passed to Action::DeleteBranch. I was passing the branch name instead of a full ref 🤦‍♂️

alessandroasm avatar Oct 11 '21 12:10 alessandroasm

I've made the changes requested. Please have a look at my reply about Action::DeleteRemoteBranch.

alessandroasm avatar Oct 14 '21 12:10 alessandroasm

marking as Draft until the remaining comments are addressed

extrawurst avatar Nov 21 '21 21:11 extrawurst

@alessandroasm are you still planning to move this forward?

extrawurst avatar Dec 29 '22 23:12 extrawurst

This issue has been automatically marked as stale because it has not had any activity half a year. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Mar 17 '24 15:03 stale[bot]