gitui icon indicating copy to clipboard operation
gitui copied to clipboard

use CredComponent for PullComponent via RefCell shared with main app

Open sum12 opened this issue 3 years ago • 6 comments

this allow the CredComponent to be reused across the all other components. Since at any time only one using compoenent (here PullComponent only for now) is visible only one these sharing entities will try to get hold of the shared component via the RefCell

sum12 avatar May 07 '21 14:05 sum12

@extrawurst I know this is probably annoying. But can you give this another approval ? I have done a make check make test and make build-release so atleast the linux part should pass the CI

(Thinking of another smaller PR just become a contributor before trying to work further on this on)

sum12 avatar May 12 '21 07:05 sum12

@extrawurst any input on this ?

sum12 avatar May 18 '21 05:05 sum12

[try 2] @extrawurst does this go in the right direction ?

sum12 avatar May 27 '21 18:05 sum12

[try 2] @extrawurst does this go in the right direction ?

sorry for not giving you feedback on this yet, I hope to be able to on the weekend

extrawurst avatar May 27 '21 19:05 extrawurst

Is this still relevant ( even after resolving the conflicts) ? @extrawurst

sum12 avatar Jul 20 '21 15:07 sum12

This issue has been automatically marked as stale because it has not had any activity half a year. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Mar 17 '24 15:03 stale[bot]