gitui icon indicating copy to clipboard operation
gitui copied to clipboard
verified publisher icon extrawurst

Continuation of Add search bar at bottom of revlog #506

Open willir opened this issue 4 years ago • 9 comments

Original pull request: https://github.com/extrawurst/gitui/pull/506

I've fixed the following comments:

  1. https://github.com/extrawurst/gitui/pull/506#discussion_r606654156
  2. https://github.com/extrawurst/gitui/pull/506#discussion_r606653856
  3. https://github.com/extrawurst/gitui/pull/506#discussion_r606654257

Please let me know whether those fixes are enough. I'm also not sure whether this way is a good way to continue work of the @WizardOhio24, if not, I'd be glad to do it an alternative way.

willir avatar Apr 25 '21 19:04 willir

@willir please look into the breaking CI so I can review this.

extrawurst avatar Apr 29 '21 19:04 extrawurst

I hope I fixed the issue. Thanks for pinging me!

willir avatar May 02 '21 00:05 willir

@willir please consider running make check locally to be sure the CI will not fail again

extrawurst avatar May 04 '21 12:05 extrawurst

@extrawurst Thanks for suggestion about make check. Hope it will pass now.

willir avatar May 08 '21 15:05 willir

@extrawurst Thanks for suggestion about make check. Hope it will pass now.

no problem. could you rebase again?

extrawurst avatar May 16 '21 12:05 extrawurst

I've merged master to find-sha.

willir avatar May 18 '21 00:05 willir

This PR is really the only thing keeping me on tig -- @willir is there any chance you'll be able to revisit it this year?

heliostatic avatar Oct 13 '21 20:10 heliostatic

Hi @heliostatic, I'll try to get back to it this coming weekend.

willir avatar Oct 19 '21 13:10 willir

@willir still planning to get back to this? putting in draft till then

extrawurst avatar Sep 18 '22 13:09 extrawurst