gitui icon indicating copy to clipboard operation
gitui copied to clipboard

Support reword in log tab & refactor external editor calls

Open WizardOhio24 opened this issue 5 years ago • 9 comments

No more do we have to go though an interactive rebase in which the exact commit reference must be known, where we then must choose 'reword' on the correct commit.

This PR provides the reword functionality on the log(commit list) tab, simply press 'r' on the commit, type in the new message and press enter to change it.

This does not do an interactive rebase in git2rs, rather a slightly more complex rebase operation which achieves the same thing (there is no such thing as an interactive rebase in git2rs/libgit2) This does not work on the first commit because it has no parent.

Linked to #32

WizardOhio24 avatar Oct 07 '20 22:10 WizardOhio24

This does work, but it doesn't keep it's commit selection prior to the change, it just goes to the top.

WizardOhio24 avatar Oct 10 '20 22:10 WizardOhio24

Fixed

WizardOhio24 avatar Oct 10 '20 22:10 WizardOhio24

With this, should the character count in the reword input box be shown? e.g, if the user wants to know if the commit message length?

WizardOhio24 avatar Feb 02 '21 20:02 WizardOhio24

It's true for commit message, I'll set the show character count to true.

WizardOhio24 avatar Feb 02 '21 20:02 WizardOhio24

Updated to master.

WizardOhio24 avatar Apr 29 '21 23:04 WizardOhio24

superseded by #672

extrawurst avatar May 17 '21 22:05 extrawurst

This has nothing to do with #672? This is about rewording commits in the log tab, nothing to do with searching.
Perhaps you meant to close #506? (Feel free, it has been superceded).

WizardOhio24 avatar May 18 '21 01:05 WizardOhio24

was too late, of course I meant to close #506

@WizardOhio24 for this to be reviewed it needs to be up to date

extrawurst avatar May 18 '21 10:05 extrawurst

going back to draft in the meantime. change it back to review once you think its ready 👍

extrawurst avatar May 27 '21 20:05 extrawurst

closing in favour of https://github.com/extrawurst/gitui/pull/1553

extrawurst avatar Feb 18 '23 20:02 extrawurst