gitui icon indicating copy to clipboard operation
gitui copied to clipboard

Fix skipping a file when staging last file in a directory

Open Tillerino opened this issue 2 months ago • 2 comments

This Pull Request partly addresses #2748.

The "error" result from the binary search was not taken into account after an update to the status tree, which lead to files being skipped when the last file in a directory was staged.

Before:

Screencast_20251029_204232.webm

(skips zzz)

After:

Screencast_20251029_204327.webm

I followed the checklist:

  • [X] I added unittests
  • [X] I ran make check without errors
  • [X] I tested the overall application
  • [X] I added an appropriate item to the changelog

Tillerino avatar Oct 29 '25 19:10 Tillerino

@Tillerino could you fix the conflicts?

extrawurst avatar Nov 29 '25 15:11 extrawurst

@Tillerino would love to see this land, are you committed to push it over the finish line?

extrawurst avatar Dec 06 '25 12:12 extrawurst

I rebased and incorporated the requested changes. Ready to go.

Tillerino avatar Dec 11 '25 08:12 Tillerino