gitui icon indicating copy to clipboard operation
gitui copied to clipboard

Build broken with rust 1.90

Open 0-wiz-0 opened this issue 2 months ago • 5 comments

Describe the bug After updating rust to 1.90 in pkgsrc, gitui 0.27.0 (the latest release) doesn't build any longer.

To Reproduce Instlal rust 1.90, try building gitui 0.27.0.

Expected behavior Build succeeds.

Screenshots build fails:

   Compiling git2-hooks v0.4.0 (/pbulk/work/devel/gitui/work/gitui-0.27.0/git2-hooks)
error: associated constant `CREATE_NO_WINDOW` is never used
   --> git2-hooks/src/hookspath.rs:214:8
    |
205 | trait CommandExt {
    |       ---------- associated constant in this trait
...
214 |     const CREATE_NO_WINDOW: u32 = 0x0800_0000;
    |           ^^^^^^^^^^^^^^^^
    |
note: the lint level is defined here
   --> git2-hooks/src/lib.rs:16:2
    |
 16 |     dead_code,
    |     ^^^^^^^^^

error: could not compile `git2-hooks` (lib) due to 1 previous error
warning: build failed, waiting for other jobs to finish...
*** Error code 101

Context (please complete the following information):

  • OS/Distro + Version: NetBSD 11.99.3/pkgsrc
  • GitUI Version 0.27.0
  • Rust version: 1.90 Additional context n/a

0-wiz-0 avatar Oct 21 '25 08:10 0-wiz-0

this is long fixed on master, we probably should cut a new release soon

extrawurst avatar Oct 22 '25 08:10 extrawurst

There are some pending PRs which should be included in a release, including one which fixes CI and compilation using future Rust compilers (and current nightly): #2739.

linkmauve avatar Oct 22 '25 14:10 linkmauve

Yes, please make a release - in pkgsrc we only package releases. Thank you.

0-wiz-0 avatar Oct 26 '25 22:10 0-wiz-0

we are closing in on a 0.28 release. any testing of nightly builds appreciated

extrawurst avatar Oct 28 '25 22:10 extrawurst

2374e00302c8821475e7c015dbfa3de348bb2340 builds fine, thanks!

0-wiz-0 avatar Oct 30 '25 10:10 0-wiz-0

0.28 is released

extrawurst avatar Dec 17 '25 12:12 extrawurst