gitui icon indicating copy to clipboard operation
gitui copied to clipboard

Cannot build because CREATE_NO_WINDOW is never used

Open Kamilcuk opened this issue 4 months ago • 1 comments

Describe the bug

When installing gitui with nix on my env, it does not build.

$ nix profile upgrade --all
warning: Found package 'nix', but it was not added from a flake, so it can't be checked for upgrades!
warning: download buffer is full; consider increasing the 'download-buffer-size' setting
error: Cannot build '/nix/store/pa5r9f6lmfwqc54ly1k600njql1si3wh-gitui-0.27.0.drv'.
       Reason: builder failed with exit code 101.
       Output paths:
         /nix/store/vjx1022dyflrgnn7vsjdy9229cnq7llk-gitui-0.27.0
       Last 25 log lines:
       >    Compiling gix-shallow v0.1.0
       >    Compiling gix-index v0.37.0
       >    Compiling ratatui v0.29.0
       >    Compiling gix-config v0.42.0
       >    Compiling gix-discover v0.37.0
       >    Compiling gix-protocol v0.47.0
       >    Compiling gix v0.69.1
       >    Compiling git2-hooks v0.4.0 (/nix/var/nix/builds/nix-build-gitui-0.27.0.drv-3091895-2781798105/source/git2-hooks)
       > error: associated constant `CREATE_NO_WINDOW` is never used
       >    --> git2-hooks/src/hookspath.rs:214:8
       >     |
       > 205 | trait CommandExt {
       >     |       ---------- associated constant in this trait
       > ...
       > 214 |     const CREATE_NO_WINDOW: u32 = 0x0800_0000;
       >     |           ^^^^^^^^^^^^^^^^
       >     |
       > note: the lint level is defined here
       >    --> git2-hooks/src/lib.rs:16:2
       >     |
       > 16  |     dead_code,
       >     |     ^^^^^^^^^
       >
       > error: could not compile `git2-hooks` (lib) due to 1 previous error
       > warning: build failed, waiting for other jobs to finish...
       For full logs, run:
         nix log /nix/store/pa5r9f6lmfwqc54ly1k600njql1si3wh-gitui-0.27.0.drv

To Reproduce

  1. Install nix user installation
  2. Install gitui with nix

Expected behavior

It should build.

Context (please complete the following information):

  • OS/Distro + Version: Rocky Linux 9.3
  • GitUI Version 0.27.0
  • Rust version: rustc 1.84.0 (9fc6b4312 2025-01-07)
  • nix channel https://nixos.org/channels/nixpkgs-unstable

Additional context

gitui is very increadibly amazing, thank you for making it, it is the best.

Kamilcuk avatar Aug 25 '25 11:08 Kamilcuk

I think a fix has already been merged, but this still fails in nixpkgs because a new release that includes the fix hasn't been cut yet.

LoganWalls avatar Aug 28 '25 12:08 LoganWalls