gitui icon indicating copy to clipboard operation
gitui copied to clipboard

Conventional Commit Popup

Open tkr-sh opened this issue 1 year ago • 4 comments

It changes the following:

  • Add a new "Conventional Commit" popup, with a feature "gitmoji" that allows quick templating messages with rich git commit messages following conventional commits.

I followed the checklist:

  • [ ] I added unittests (I don't think that there are unittests on popup usually)
  • [X] I ran make check without errors
  • [X] I tested the overall application
  • [ ] I added an appropriate item to the changelog

Also, I know that the UI and the UX is different than the one of Fuzzy finder, but I prefer this one personally (I think that the UX is just better tbh), and it's still easy to follow, even for non vim users :) !

Video: asciicast Note: the video is kinda glitched because of the emojis, but everything is aligned

tkr-sh avatar Jan 16 '25 00:01 tkr-sh

Hi @tkr-sh. Thank you for your effort and for sharing this.

If you're still interested, would you be so kind and add a few key screenshots (or even a video capture) that describe this change so we can discuss based on this? I guess this might help this patch along. It's unlikely many people will join the discussion if they have to assert whether a 1k patch does any shenanigans on their development machines or spool up a cloud instance for every iteration and I take it that there will be discussions.

naseschwarz avatar Mar 21 '25 06:03 naseschwarz

Sure. Tho in theory, it could still work and have untrusted code. In any case, this should be reviewed, and it's straightforward enough so that people realize that there are no shady stuff. I'll do that in a few hours

tkr-sh avatar Mar 21 '25 12:03 tkr-sh

Thank you!

Tho in theory, it could still work and have untrusted code.

Sure, screenshots won't change the level of trust by much. They're not so much to inspire trust but to provide the input that's needed for a discussion that can move the PR along.

naseschwarz avatar Mar 21 '25 12:03 naseschwarz

Added a video and fixed/upgraded some stuff @naseschwarz @extrawurst

tkr-sh avatar Mar 23 '25 19:03 tkr-sh