gitui icon indicating copy to clipboard operation
gitui copied to clipboard

Some CTRL key combinations don't work on the commit popup

Open Huliiiiii opened this issue 1 year ago • 2 comments

To Reproduce Steps to reproduce the behavior:

  1. Bind CTRL-Enter to commit, CTRL-i to open_commit_editor
  2. Open commit popup
  3. Press CTRL-Enter
  4. Insert new line
  5. Press CTRL-i
  6. Insert 4 spaces

Expected behavior CTRL-Enter should do commit and CTRL-i should open editor

Screenshots If applicable, add screenshots to help explain your problem.

Context (please complete the following information):

  • OS/Distro + Version: Ubuntu 24.04.1 LTS
  • GitUI Version gitui nightly 2024-11-29 ()
  • Rust version: 1.82

Additional context Add any other context about the problem here.

Huliiiiii avatar Dec 01 '24 03:12 Huliiiiii

I noticed this, too, and am sad. I instinctively hit ctrl+enter to try to commit – every time – and wanted to make that work (instead of ctrl+d which is the default.)

For the record, the RON configuration to change the binding that I tested was:

(
  commit: Some(( code: Enter, modifiers: "CONTROL")),
)

When configured with the above, the gitui user interface does actually draw the symbols for ctrl+enter on the commit dialog's "do commit" button but pressing ctrl+enter is interpreted as if only enter was pressed: it types a new-line instead of performing the commit.

(gitui versions: nightly 2024-12-07 & nightly 2024-08-10)

stephenmartindale avatar Dec 07 '24 10:12 stephenmartindale

Ctrl+Right/Left as well as Ctrl+Backspace would be nice as well. Navigate by word and delete by word respectively.

savchenko avatar Apr 21 '25 11:04 savchenko