Some CTRL key combinations don't work on the commit popup
To Reproduce Steps to reproduce the behavior:
- Bind CTRL-Enter to
commit, CTRL-i toopen_commit_editor - Open commit popup
- Press CTRL-Enter
- Insert new line
- Press CTRL-i
- Insert 4 spaces
Expected behavior CTRL-Enter should do commit and CTRL-i should open editor
Screenshots If applicable, add screenshots to help explain your problem.
Context (please complete the following information):
- OS/Distro + Version: Ubuntu 24.04.1 LTS
- GitUI Version gitui nightly 2024-11-29 ()
- Rust version: 1.82
Additional context Add any other context about the problem here.
I noticed this, too, and am sad. I instinctively hit ctrl+enter to try to commit – every time – and wanted to make that work (instead of ctrl+d which is the default.)
For the record, the RON configuration to change the binding that I tested was:
(
commit: Some(( code: Enter, modifiers: "CONTROL")),
)
When configured with the above, the gitui user interface does actually draw the symbols for ctrl+enter on the commit dialog's "do commit" button but pressing ctrl+enter is interpreted as if only enter was pressed: it types a new-line instead of performing the commit.
(gitui versions: nightly 2024-12-07 & nightly 2024-08-10)
Ctrl+Right/Left as well as Ctrl+Backspace would be nice as well. Navigate by word and delete by word respectively.