gitui icon indicating copy to clipboard operation
gitui copied to clipboard

`line_break` in `theme.ron` is interpreted incorrectly

Open savchenko opened this issue 1 year ago • 2 comments

Describe the bug Line-breaks colour is rendered verbatim, as the HEX colour.

To Reproduce Add the following to your theme.ron

( 
  line_break: Some("#005e8b")
)

Expected behavior Hunks in gitui are exactly the same as in the git diff and files on disk.

Screenshots image

image

Context (please complete the following information):

  • OS/Distro + Version: Debian 12
  • GitUI Version: nightly 2024-06-28 (95e1d4d) as well as the release build from https://github.com/extrawurst/gitui/commit/4ef633a75a3581936d0da9aade7af8ed7aad98ab
  • Rust version: rustc 1.76.0 (07dca489a 2024-02-04)

Additional context The 005e8b string is not a git commit hash, e.g. git show 005e8b returns nil.

savchenko avatar Jul 27 '24 04:07 savchenko

@savchenko The line_break parameter is set to a string character, not a ~~color~~.

image

wugeer avatar Sep 03 '24 08:09 wugeer

yeah its a hack. that should be cleaned up at some point

extrawurst avatar Sep 03 '24 10:09 extrawurst