Add support for recursive blame
This Pull Request closes #2194.
It changes the following:
- Replace
BlameFilePopup.blame: Option<BlameProcess>withBlameFilePopup.blame_stack: Vec<BlameProcess>. This involved changing any references to it, which happened to be a fair amount. - Add keybinding for going back to a previous blame (
b). - Make keybinding for
blame(Shift+B) work in thepopups/blame_file.rsview, where it will take the commit and open a blame from that. - Add hints for
blameandbackkeybindings in blame_file. - (edit) Add recursive blame feature to
popups/file_revlog.rs
I followed the checklist:
- [ ] I added unittests (can add if you think it's necessary)
- [x] I ran
make checkwithout errors (this reached the same pointmasterdoes, which fails ontest_pre_commit_py. Does this need an issue?) - [x] I tested the overall application (used it to make these commits! Haha)
- [x] I added an appropriate item to the changelog
Thanks for tackling this. I only had one comment or request to rework. Would love to add this feature
lets fix the ci, and i noticed that when the popup is open the command bar goes blank, that seems wrong
lets fix the ci, and i noticed that when the popup is open the command bar goes blank, that seems wrong
Will get on that when I get a chance! Appreciate the update.
Ah, that makes sense. So, to clarify, do you want to
a)have somewhat of a non-popping stack,b)just nix thebackfunctionality altogether, orc)did you have something else in mind?
Also @extrawurst I'm not sure if you saw my other comment, but I needed some more info.