gitui icon indicating copy to clipboard operation
gitui copied to clipboard

Cannot commit with empty e-mail.

Open Densaugeo opened this issue 10 months ago β€’ 2 comments

Describe the bug When git is configured with an empty e-mail address, gitui does not allow commits.

To Reproduce Steps to reproduce the behavior:

git config --global user.email "<>"
git init foo
cd foo
echo "some content" > a_file.txt
gitui
# Stage a_file.txt
# Hit "c" to start a commit
# Type any commit message and hit enter

Expected behavior A new commit should be created.

Screenshots image

Context (please complete the following information):

  • Fedora 39
  • GitUI 0.24.3
  • Git 2.44.0

Densaugeo avatar Apr 12 '24 17:04 Densaugeo

That is literally not an empty string πŸ˜‚

pretty sure that’s an upstream issue in libgit2

extrawurst avatar Apr 12 '24 17:04 extrawurst

For some reason, I though git didn't allow actual empty strings and used <> to represent them. Not sure where I got the idea.

Anyway, I did a quick test with email = in my .gitconfig file, and I got a similar error message:

image

Densaugeo avatar Apr 12 '24 20:04 Densaugeo