gitui icon indicating copy to clipboard operation
gitui copied to clipboard
verified publisher icon extrawurst

Line numbers

Open my-tien opened this issue 2 years ago • 4 comments

Hi, thank you for this cool project!

What do you think about having line numbers in the file view and diff view? I saw that the blame component already has it. Is there a reason why the others don’t display line numbers?

Do you think this feature is straightforward enough for a first contribution? I guess one could roughly follow the code for the blame component to implement this for the file view?

my-tien avatar Jun 04 '23 20:06 my-tien

the diff calculation and rendering will get an overhaul when I switch it to an external diffing solution. I think this will be a smart addition once that happens. I would not try to work it into the current mess

extrawurst avatar Jun 19 '23 12:06 extrawurst

is the file view also planned for an overhaul? I saw that ratatui Spans are used atm which are deprecated.

my-tien avatar Jun 24 '23 15:06 my-tien

Spans were just renamed to Row. Gitui was adapted accordingly.

extrawurst avatar Jun 24 '23 18:06 extrawurst

This issue has been automatically marked as stale because it has not had any activity half a year. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Mar 17 '24 15:03 stale[bot]