gitui icon indicating copy to clipboard operation
gitui copied to clipboard

improper background color patterns when scrolling file content

Open unixoidal opened this issue 2 years ago • 14 comments

In the "Files [3]" I am trying to view the content of the files. When scrolling some background colors are not updated and a green-pink mess is seen. Unfortunately, I cannot attach the full screenshot due to private owned code. But please see the right side of guiui window where color glitches are seen.

OS/Distro: Debian 11 (Bullseye), Linux deb-ak 5.10.0-19-amd64 #1 SMP Debian 5.10.149-2 (2022-10-21) x86_64 GNU/Linux Terminals used where issue is observed: -- MATE Terminal -- xterm Rust version: 1.48 GitUi version: 0.22.1

image

unixoidal avatar Feb 17 '23 13:02 unixoidal

never seen those. would be good to get a reproducible case of this

extrawurst avatar Feb 17 '23 13:02 extrawurst

Let me know please how to turn on the debug/logs so I could provide more info.

unixoidal avatar Feb 17 '23 21:02 unixoidal

https://github.com/extrawurst/gitui#diagnostics

extrawurst avatar Feb 19 '23 11:02 extrawurst

image image

There is a very serious color crash, resulting in a lot of content is basically unviewable

cycle2zhou avatar Aug 09 '23 15:08 cycle2zhou

It is tested that this problem only exists in the native terminal of macos, and iterm2 and vscode do not have this problem

cycle2zhou avatar Aug 10 '23 02:08 cycle2zhou

works for me on the native macOS terminal: Screenshot 2023-08-10 at 12 54 04

extrawurst avatar Aug 10 '23 10:08 extrawurst

The files TAB has a higher probability of appearing, which is a few random occurrences, and I generally look at a few more files

cycle2zhou avatar Aug 10 '23 11:08 cycle2zhou

After the Show ANSI colors feature is turned off, there are no scrambled colors, but the selected colors cannot be seen

cycle2zhou avatar Aug 10 '23 11:08 cycle2zhou

can't reproduce.

maybe you can checkout a few other tui apps that use the same framework I do to see if they behave weird aswell: https://github.com/ratatui-org/ratatui/wiki/Apps-using-Ratatui

extrawurst avatar Aug 10 '23 11:08 extrawurst

gitui.log

https://github.com/extrawurst/gitui/assets/33155330/48c9880a-4664-4cfb-8605-446536984de6

Above is the log and replay video to see if it helps

cycle2zhou avatar Aug 10 '23 14:08 cycle2zhou

See above regarding other tools to compare please

extrawurst avatar Aug 10 '23 14:08 extrawurst

I tried bottom, bandwhich, gping, and nothing like gitui

cycle2zhou avatar Aug 10 '23 14:08 cycle2zhou

No idea :(

extrawurst avatar Aug 10 '23 14:08 extrawurst

This issue has been automatically marked as stale because it has not had any activity half a year. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Mar 17 '24 15:03 stale[bot]