gitui icon indicating copy to clipboard operation
gitui copied to clipboard

Use filetreelist crate

Open abergmeier opened this issue 2 years ago • 7 comments

No longer safe Status inside of FileTreeItem. For Status storage, now introduced a new Item, which contains Status alongside FileTreeItem.

Note that FileTreeItemKind is no longer publicy available - thus we cannot store this enum anywhere anymore.

I followed the checklist:

  • [ ] I added unittests
  • [x] I ran make check without errors
  • [x] I tested the overall application
  • [x] I added an appropriate item to the changelog

abergmeier avatar Jan 15 '23 15:01 abergmeier

~~So far change component shows no diff - not sure why~~

abergmeier avatar Jan 15 '23 19:01 abergmeier

I think for being able to write unittests I would need to extract a lot of traits for components.

abergmeier avatar Jan 15 '23 20:01 abergmeier

All good the tree component itself is pretty well tested

extrawurst avatar Jan 15 '23 22:01 extrawurst

While reviewing noticed that it still has its own FileTreeItems instead of using the one from filetreelist-crate. We should make it use the crate one

extrawurst avatar Jan 29 '23 08:01 extrawurst

putting in draft till the next round of reviews

extrawurst avatar Jan 29 '23 08:01 extrawurst

While reviewing noticed that it still has its own FileTreeItems instead of using the one from filetreelist-crate. We should make it use the crate one

The reason is that filetreelist crate knows nothing about status. If you want to use it I see 2 basic ways of doing it:

  1. Introduce status to filetreelist crate
  2. Have a separate "list" for status

How do you want handle that?

abergmeier avatar Jan 29 '23 08:01 abergmeier

This issue has been automatically marked as stale because it has not had any activity half a year. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Mar 17 '24 15:03 stale[bot]