gitui icon indicating copy to clipboard operation
gitui copied to clipboard

Display commit description in addition to hash in file view

Open alexmaco opened this issue 3 years ago • 2 comments

It changes the following:

  • displays the commit name besides the hash in the file view

I followed the checklist:

  • [ ] I added unittests
  • [x] I ran make check without errors
  • [x] I tested the overall application
  • [ ] I added an appropriate item to the changelog

alexmaco avatar Oct 06 '22 11:10 alexmaco

Screenshot 2022-10-15 at 12 25 39

im not convinced of this yet, this rarely fits the screen. maybe we just introduce a shortcut to open the current commit detail popup from the files component, this will contain the commit desc. aswell

extrawurst avatar Oct 15 '22 10:10 extrawurst

this rarely fits the screen

There are multiple things that can't be shown fully when the screen is too small to fit them. But most often it fits on a terminal for me.

The main use of this is remembering which commit this is exactly, and by proxy, sometimes which branch. It's easy to forget which commit does the current file view point at, and even the start of the message is usually enough to distinguish between several commits as a mnemonic.

Do you see any substantial downsides to having an at-a-glance disambiguation?

maybe we just introduce a shortcut

Imo there are many shortcuts already, but no consistent model of interaction yet (hence, #1383).

Being able to switch to a commit view would be really nice if it would always work like a toggle, regardless of how the file view was opened, but that would introduce some overlap with the current use of Esc, and some unpredictable (i.e. special-cased) view switching. So off-hand it seems like something that's easier to get wrong than right without some more detailed UX consideration.

alexmaco avatar Oct 15 '22 22:10 alexmaco

ok lets have a changelog entry and it can be merged

extrawurst avatar Nov 05 '22 15:11 extrawurst