gitui
gitui copied to clipboard
Factor out file history lookup into AsyncFileLogJob
This PR partly addresses #1115. As of 2022-08-03, it is still a draft.
It changes the following:
- It factors out getting commit info into
AsyncFileLogJob
. It does not move getting commit info into a worker thread.
I followed the checklist:
- [ ] I added unittests
- [ ] I ran
make check
without errors - [ ] I tested the overall application
- [ ] I added an appropriate item to the changelog
@extrawurst Currently, components can use AsyncLog::get_slice
to get a slice of the revlog even if it has not been fully read yet. In this PR, I want to first implement the existing functionality using AsyncJob
, so it seems I would need something similar to get_slice
. Is that assumption correct? If so, can this be done using AsyncJob
? There is set_progress
, but Iām not sure whether this is the right function to use. Iām even starting to wonder whether my overall approach is correct.
the AsyncLog specific do not have to be squeezed into the trait functions run/progress
. check out AsyncSyntaxJob::result
it is not part of the generic interface and can be used specific to the use case. Not sure this answers your question. WDYT?
This issue has been automatically marked as stale because it has not had any activity half a year. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.