gitui icon indicating copy to clipboard operation
gitui copied to clipboard

Create multi-line commit messages

Open florealcab opened this issue 3 years ago • 9 comments

Is your feature request related to a problem? Please describe. Commit with gitui allow only one commit line, without commit description (like is allowed with commit -m command)

Describe the solution you'd like Allow to add a description to the commit: with a new description field, or simply with a multi-line commit

florealcab avatar Mar 10 '22 15:03 florealcab

If you press the Open editor key (default is ^e) while the commit window is open, you can edit the commit message using a text editor (similar to what git commit does).

kosayoda avatar Mar 20 '22 21:03 kosayoda

See also #509

extrawurst avatar Mar 21 '22 07:03 extrawurst

If you press the Open editor key (default is ^e) while the commit window is open, you can edit the commit message using a text editor (similar to what git commit does).

Yes it did the trick thank you :)

See also #509

Better to do that! Hope will be merged soon :D

florealcab avatar Mar 21 '22 09:03 florealcab

I'm here for this same reason. A message in the commit window saying the user to press ctrl+e for multi-line commits, while we make something better, wouldn't hurt.

Zeioth avatar Apr 04 '22 20:04 Zeioth

marking as good first issue, since its just about finishing the draft PR #509

extrawurst avatar Aug 28 '22 11:08 extrawurst

Any updates on this? @extrawurst

IgnisDa avatar Mar 01 '23 00:03 IgnisDa

I'll have a look to see if I can finish off https://github.com/extrawurst/gitui/pull/1309.

@extrawurst - are you open to assessing https://github.com/rhysd/tui-textarea/ for this purpose? I ask not yet knowing the gitui codebase (hence implications) nor your attitude to deps. I've tried a couple of the examples and it seems nice on the face of it not to have to roll-your-own scrolling & cursor etc. It might also have other uses within gitui perhaps?

If you're open to it I'll explore that route first briefly as a test of fit and report back. If not I'll disinter the above PR and see what I might do with it.

crispinb avatar May 23 '23 02:05 crispinb

Ah. I see now there's an issue already suggesting use of tui-textarea, which should give us multiline input for free. So never mind for now. I'll keep an eye on that issue in case help's needed at any stage. It would be a good one to get over the line.

crispinb avatar May 24 '23 07:05 crispinb

closing favor of #2045

extrawurst avatar Feb 14 '24 10:02 extrawurst