gitui icon indicating copy to clipboard operation
gitui copied to clipboard

Published 20 hours ago • verified publisher icon extrawurst

Bump clap to v3

Open weihanglo opened this issue 3 years ago • 2 comments

This Pull Request fixes/closes #1065.

It changes the following:

  • Bump clap to v3: Mainly replacing deprecated functions/items. A notable change is that AppSettings::StrictUtf8 is now default behavior so we need to allow invalid UTF8 on args related to path. Also adding a new debug_assert provided by clap itself

I followed the checklist:

  • [x] I added unittests
  • [x] I ran make check without errors
  • [x] I tested the overall application
  • [ ] I added an appropriate item to the changelog

weihanglo avatar Jan 07 '22 09:01 weihanglo

cool! thanks for tackling this. feel free to join us on discord aswell :) will review it later today

extrawurst avatar Jan 07 '22 11:01 extrawurst

oh oh.

We will support the last two minor Rust releases (MSRV, currently 1.54.0)

that is a problem

extrawurst avatar Jan 07 '22 11:01 extrawurst

done via 4a0e58a

extrawurst avatar Aug 17 '22 16:08 extrawurst