python-shell icon indicating copy to clipboard operation
python-shell copied to clipboard

getVersionSync test fails in appveyor

Open Almenon opened this issue 7 years ago • 9 comments

It says that the version is a empty string. No idea why - passes locally. I should try using a different computer and seeing if it passes there.

The other interesting thing is that al the tests passed on ubuntu. Why would the test only fail on windows? I'm using a windows computer currently so it should fail locally if that's the case.

Almenon avatar Oct 07 '18 15:10 Almenon

I just tried on a different computer and it passes locally there too :/

Almenon avatar Oct 13 '18 01:10 Almenon

maybe it's because I'm on a different version of node. Ideally I should be doing my tests against a matrix of different node & python versions.

Almenon avatar Oct 13 '18 01:10 Almenon

it looks like getverysionsync also fails with python 2

https://ci.appveyor.com/project/Almenon/python-shell/build/job/7h74qfvwjq2gpe57

Almenon avatar Oct 13 '18 01:10 Almenon

and fails with python 3 and node 10 too. So it's not related to the python/node version

https://ci.appveyor.com/project/Almenon/python-shell/build/job/do630jekia3ayplq

Almenon avatar Oct 13 '18 02:10 Almenon

Not sure how I didn't notice it but all the tests are failing :/

Almenon avatar Nov 18 '18 20:11 Almenon

All of the ubuntu tests are passing now with https://github.com/extrabacon/python-shell/commit/61a8fc9455f27e33a89bd632f51e0b7921b1edb1

Almenon avatar Nov 18 '18 21:11 Almenon

I've decided to comment them out on master untill someone fixes them. The methods the tests test are not very important so if the unit tests don't run it's not that big of a deal. Having a 100% passing unit test suite is more important.

Almenon avatar Dec 18 '18 17:12 Almenon

Uhm maybe they also should be commented on the README file because I was trying to use them haha

https://github.com/extrabacon/python-shell/tree/5f39ad4d1b59f88f6450651754085c37d5782696#getversionpythonpathstring

Anyway running a small python script like this does the trick

import platform
print(platform.python_version())

ghost avatar Dec 19 '18 09:12 ghost

They still work, just not in appveyor

Almenon avatar Dec 19 '18 16:12 Almenon