bazaar icon indicating copy to clipboard operation
bazaar copied to clipboard

Drop dev dependencies

Open luceos opened this issue 8 years ago • 5 comments

Anyone using bazaar most likely does not need any dev dependencies, let's not install those in our vendor.

luceos avatar Apr 28 '17 10:04 luceos

Well, that's why they are called dev dependencies!

People should install bazaar with --no-dev / --update-no-dev flag

Bazaar itself already runs composer in production mode. (It's not clearly visible because it's the default behavior; in the official composer CLI the absence of the --no-dev flags sets the setDevMode(). Example: https://github.com/composer/composer/blob/master/src/Composer/Command/InstallCommand.php#L104)

clarkwinkelmann avatar Apr 28 '17 10:04 clarkwinkelmann

I meant that bazaar should install packages without including dev dependencies by default. I wasn't specifically talking about installing bazaar 😁

luceos avatar Apr 28 '17 12:04 luceos

It's not working then? It should :sweat_smile:

clarkwinkelmann avatar Apr 28 '17 12:04 clarkwinkelmann

It's not about dist mode, it's about dev mode:

https://github.com/composer/composer/blob/master/src/Composer/Command/InstallCommand.php#L105

luceos avatar Apr 28 '17 12:04 luceos

Oh that's what you said too, but doesn't composer set dev mode if left out.. Seems like it doesn't. We'd have to confirm this anyway.

luceos avatar Apr 28 '17 14:04 luceos