js-pdk icon indicating copy to clipboard operation
js-pdk copied to clipboard

consider making resulting modules `reactor` modules

Open zshipko opened this issue 9 months ago • 2 comments

Running a js-pdk plugin with extism-wamr gives a warning:

[15:03:41:772 - 7F54D39B9740]: warning: a module with WASI apis should be either a command or a reactor

We may want to add an _initialize export to fulfill this expectation

zshipko avatar May 08 '24 18:05 zshipko

Can we just add this as an export to the core crate? What do we need to do to accomplish this?

bhelx avatar Jun 14 '24 21:06 bhelx

Yeah we could probably just add an empty _initialize function. The main blocker is just trying to understand how important this change really is. WAMR is the only runtime that has an issue with it, and even there it's just a warning.

zshipko avatar Jun 14 '24 21:06 zshipko