hoverzoom video-settings get reset to default when user deletes all cookies.

[tokariu]

Description of the problem

when I make changes to the video section of the settings, these will always get reset after I delete all cookies.

Steps to reproduce the problem (include image url here)

1. change video settings to: 1) silence zoomed videos, and 2) volume of non-muted videos: 0% - save settings.
2. test it, it's working. now clear all cookies in Firefox.
3. open hover zoom+ addon-settings and see that all settings in the video section are set back to default values (unticked silence zoomed videos, 25% volume for non-muted videos).

OS version, extension version (Chrome only, Firefox is not supported)

W7, Version 1.0.132, Firefox v62.x I see Firefox is not supported, but I hope it could get fixed anyway. Even if not, maybe this bug is also present in Chrome (I can't test it), so lets keep this bug noted here.

[tokariu]

in the meanwhile I had time to elaborate the issue a bit further..

one thing i discovered is: video settings won't get reset always when I delete all cookies/cache etc. sometimes the settings are still there. Then after a while (hours later) when I startup my browser again, the video settings are gone again - without changing or deleting any cookies/cache/settings in the meantime. this behaviour is really ridiculous and annoying. what could it be that causes such issues?

Update:

the issue is not only affecting the video section of the settings. it also affects the other sections like appearance (the zoomed picture scaling setting for instance is also getting reset). so it seems all settings get reset at some point.

@extesy could you help us elaborate if this issue is due to firefox or a bug in this extension?

[DParsons01]

I have the same issue and was here to post it but will just second this one. very tired of constantly having to change my settings back.

firefox browser also.

[tokariu]

the problem is the addons saves the preferences in the "local storage". but "local storage" gets deleted every time you close the browser or clear history (if this privacy settings are enabled).

the addon should not save preferences to local storage, and rather use: %profilefolder%\browser-extension-data\extension\storage.js

then the settings wouldn't be always reset on browser restarts.

@extesy is it possible to make some adjustments to make it work?

[tokariu]

https://github.com/extesy/hoverzoom/blob/509d03beb555aabb6e10dea8121ba890be2698a5/js/options.js#L70

that's is the concrete problem here:

// Saves options to localStorage.
// TODO: Migrate to https://developer.chrome.com/extensions/storage
function saveOptions() {
...

waiting for the migration for so long...

[extesy]

@tokariu You seem to know enough about javascript and browsers, why don't you send a pull request?

[tokariu]

@extesy ahh don't get me wrong, I don't want to stress with that bugfix, I was just eagerly but patiently waiting for it to come! and well, I'm honored that you might think I could do this.. but the reality is, i never did anything git/-hub related yet even though I might be able to get the code working. Unfortunately I'm too busy in RL with things that cannot be postponed, so that I simply don't have the time to dig into it.. otherwise I'd have done it already, for sure!