DeckTracker icon indicating copy to clipboard operation
DeckTracker copied to clipboard

Improve presentation of opponent deck types

Open AustinYQM opened this issue 8 years ago • 8 comments

Running into strange issue where I have 1 game with a deck and that one game is registering as two deck types.

Here is an image of the tracker.

Here is my current Decktypes.txt for those two deck types.

||Multicolored (FJS)|Colors.Contains("Fire","Justice","Shadow")
|||Infinite Gunsmiths|Cards.ContainsAny(2,"Cabal Spymaster","West-Wind Herald","Calderan Gunsmith")
|||Armory|Cards.ContainsAny(3,"Starsteel Daisho","Icaria, the Liberator","Smuggler's Stash","Rakano Artisan","Quarry","Throne Warden","Harsh Rule","Rise to the Challange","Auric Runehammer")

AustinYQM avatar Jun 10 '17 19:06 AustinYQM

Not quite related, but shouldn't Infinite Gunsmith be under FPS instead

ghost avatar Jun 10 '17 20:06 ghost

Yeah I've since moved it! Noticed it after I posted those pictures.

AustinYQM avatar Jun 10 '17 20:06 AustinYQM

This is actually by design. It's not counted twice - see that "All Games" is still one? It's because your deck is both Armory and FJS at the same time. The reason is because I wanted to make the right list into a tree view instead and just haven't yet figured it out how to display trees in WPF. With the tree structure all child nodes are aggregated into the parent node so it makes sense. I agree that it looks somewhat confusing in the flat list.

extesy avatar Jun 10 '17 21:06 extesy

For example you want to know your winrate against all FJS decks and not just "all FJS except Armory". So in order to compute this winrate correctly you have to really count all FJS decks, including all subtypes.

extesy avatar Jun 10 '17 21:06 extesy

Gotcha. So it isn't something I have broken. I will continue adding deck types than.

AustinYQM avatar Jun 10 '17 22:06 AustinYQM

Thanks for the pull request! Looks great, I'll add the updated list into the next version.

extesy avatar Jun 11 '17 00:06 extesy