Fake Provider's ValueMap field is inconsistent

[shuheiktgw]

Describe the bug While working on https://github.com/external-secrets/external-secrets/issues/2835, I noticed the fake provider has a field called ValueMap, which is only referenced from the GetSecretMap method.

There are two types of providers, one has two layered secrets, such as Google Secret Manager Provider and the other one has three layered secrets, such as Kubernetes Provider. IIUC, the Fake Provider belongs to the former group, but it contains three layered secrets (ValueMap). This is unintuitive, and if we need to support the GetSecretMap method for the fake provider, instead of adding the ValueMap field, it would be much more consistent if we take the same approach as the Google Secret Manager Provider does.

WDYT? 🤔

Suggestions

1. Deprecate the ValueMap field and remove it from the Fake Provider documentation.
2. Fix the GetSecretMap method by taking the same approach as the Google Secret Manager Provider. Note that we must keep supporting the old behavior until we remove the ValueMap field itself for backward compatibility.

[vsantos]

Hello @shuheiktgw, I'm quite new to open-source, and I'm wondering if I can work on this fix to learn more about the external-secrets project and its processes. Is that okay? Even if I take a while to finish? Since this bug doesn't sound critical, it seems an excellent opportunity to start with.

[shuheiktgw]

Sure!

[shuheiktgw]

Just FYI, but we still need to remove the deprecated value map field, so I'll keep the issue open until then.

• https://github.com/external-secrets/external-secrets/pull/2884

[github-actions[bot]]

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 30 days.

[github-actions[bot]]

This issue was closed because it has been stalled for 30 days with no activity.