extentreports-dotnet-cli
extentreports-dotnet-cli copied to clipboard
extent-framework
Feature/fix categories parsing
Categories are output as property name-value pairs as of NUnit 3. e.g. <property name="Category" value="SuperFancyCategoryName" />
See: https://nunit.org/files/testresult_30.txt
Probably should change this add support for the version 3 XML schema rather than overwriting support for version 2
Categories are output as property name-value pairs as of NUnit 3. e.g.
<property name="Category" value="SuperFancyCategoryName" />See: https://nunit.org/files/testresult_30.txt
Probably should change this add support for the version 3 XML schema rather than overwriting support for version 2
Yes, that's right, that's how categories are handled in the version 3. Having a new dedicated parser for version 3 is definitely a good idea.
Having a new dedicated parser for version 3 is definitely a good idea.
Maybe. But for now, I would suggest editing the pull request to include both the if (parser(elem, "categories").Any()) and if (parser(elem, "properties").Any()) sections of the code so that this parser works with results from all versions of NUnit.
Having a new dedicated parser for version 3 is definitely a good idea.
Maybe. But for now, I would suggest editing the pull request to include both the
if (parser(elem, "categories").Any())andif (parser(elem, "properties").Any())sections of the code so that this parser works with results from all versions of NUnit.
Speaking in terms of clean code, I am not sure whether that's a good solution; it will fix the issue but it will introduce a kind of code smell, if you ask me. If you want to keep it simple, I would rather give up the compatibility with NUnit 2, which is no longer maintained. But I leave the final decision to you.
