session icon indicating copy to clipboard operation
session copied to clipboard

Adds the ability to implement a different cookie signing scheme

Open NigelKibodeaux opened this issue 11 years ago • 7 comments

NigelKibodeaux avatar Nov 18 '14 00:11 NigelKibodeaux

Hi @NigelKibodeaux , what was the reason for closing the PR?

dougwilson avatar Nov 18 '14 20:11 dougwilson

@dougwilson I found a bug. I'll resubmit when I confirm my fix :)

NigelKibodeaux avatar Nov 18 '14 20:11 NigelKibodeaux

Ok, though you can just update the existing PR by adding new commits on your master branch, for the future :)

dougwilson avatar Nov 18 '14 21:11 dougwilson

@jonathanong didn't you have a lot of wip with keygrip and signing and things?

Fishrock123 avatar Nov 20 '14 01:11 Fishrock123

@Fishrock123 yup. i had a big PR but am waiting for a second opinion and stuff. I think @dougwilson said he's handling it

jonathanong avatar Nov 20 '14 01:11 jonathanong

oh i think i merged it into master. there was an issue @dougwilson wanted to fix before pushing

jonathanong avatar Nov 20 '14 01:11 jonathanong

None of that has to do with this PR, though.

dougwilson avatar Nov 20 '14 01:11 dougwilson