session
session copied to clipboard
expressjs
use proxies for session data
So that we can check that the store actually exists (#4) and whatever else we want.
req.session.set('thing.property', stuff)
req,session.get('thing.property')
Would be removed of favour of Proxies, eventually. In like a decade when they actually land.
A big issue would be people being idiots and assigning stuff onto the data object or get()-ed objects.
Citating the example in README.md, you can add user-specific properties in this way
var sess = req.session;
if (sess.views) {
sess.views++;
} else {
sess.views = 1;
}
you can even store nested objects
Yes, I know that, but I'm guessing why it should be necessary? you can already interact with session using getter/setter.
@MichaelCereda to know if the session was modified to write it back to the store.
ok so you need to fire an event when session "data" is changed...isn't it?
In order to implement this, we would probably need to have it on a different property of req in order to not change the way it works currently. If someone wants to do something like this they may be better off looking into another library.
BUT, if it were a configuration option like asStore: true and completely change the behaviour of the req.session object, then it would be okay and non-breaking. Then again all that extra code for event firing and storing might increase the code-base by more than twice LoC, so we might as well have a different version that behaves like that.
@ZombieHippie this would just be a major version bump, i.e. breaking. Also, there is no event firing here, it's just keeping a dirty flag.
this would just be a major version bump, i.e. breaking
@dougwilson I think you are right.
Yes, a major release will be a good thing and allows to implement other breaking feature requests.
i don't think this is worth it unless you allow atomic updates on each .get(). here's how i think sessions are supposed to look like: https://github.com/aheckmann/koa-mongodb-session
Thank you for the example, it should help us understand your suggestions. On Jun 17, 2014 3:01 AM, "Jonathan Ong" [email protected] wrote:
i don't think this is worth it unless you allow atomic updates on each .get(). here's what i think is how sessions are supposed to look like: https://github.com/aheckmann/koa-mongodb-session
— Reply to this email directly or view it on GitHub https://github.com/expressjs/session/issues/46#issuecomment-46278035.
Is this still being pursued for 2.0.0? I also don't see a 2.0.0 branch, but there is a milestone. Any timeline?
I'd love to play with this. Or push a branch that does something interesting and make a PR and discuss it.
