session icon indicating copy to clipboard operation
session copied to clipboard

Published 20 hours ago • verified publisher icon expressjs

Implement custom cookie signature

Open roblabla opened this issue 7 years ago • 2 comments

This is an updated version of #98, that applies properly on current master.

roblabla avatar Aug 01 '16 13:08 roblabla

Looks like the PR is marked as failed because there are not enough tests to cover all the changes made in the PR. Please update the tests to try to cover all added code paths :)

dougwilson avatar Aug 15 '16 19:08 dougwilson

Done with all your suggestions :). I think it should be compatible with previous versions now. The s: is only appended in the default signature. In my view, it's the job of the signature module to append it if it needs it (my patch doesn't need it). This allows express-session to be compatible with php's PHPSESSID without much trouble.

roblabla avatar Aug 16 '16 08:08 roblabla