serve-index icon indicating copy to clipboard operation
serve-index copied to clipboard

feat(sort): Add sort option - micah/35/sort

Open micahstubbs opened this issue 6 years ago • 13 comments

A small PR that adds user-configurable sort for html outputs

Fix #35

a fork of @thaiat's nice PR https://github.com/expressjs/serve-index/pull/41 with a small amount of additional work to get the Travis CI and Appveyor tests to pass.

micahstubbs avatar Aug 13 '18 02:08 micahstubbs

yea, done. thought it might be related to the linting problem, looks like it's not now. thanks for watching this one 😄

and also, thanks for introducing to me https://github.com/eslint/eslint-plugin-markdown had never noticed this particular eslint plugin before

micahstubbs avatar Aug 13 '18 03:08 micahstubbs

🎉 hooray, tests are green

micahstubbs avatar Aug 13 '18 03:08 micahstubbs

Nice! I'm pretty much about to go to sleep for work in the morning and will take a look as soon as I can and get this feature landed 😴

dougwilson avatar Aug 13 '18 03:08 dougwilson

@dougwilson is there anything I can do to improve this PR?

micahstubbs avatar Aug 23 '18 06:08 micahstubbs

I will take a look when I get to a computer.

dougwilson avatar Aug 23 '18 12:08 dougwilson

Are there any plans to merge this PR? Easily sorting by date would be very beneficial.

brianreeve avatar Jan 11 '19 15:01 brianreeve

know that @dougwilson was busy back in August, but maybe, just maybe there's a bit more reviewer bandwidth here in the new year 😄

micahstubbs avatar Jan 14 '19 06:01 micahstubbs

@dougwilson i could use this too. any chance on a merge?

mhamann avatar Feb 18 '19 05:02 mhamann

Ring ring? Sorely missing feature!

mayeaux avatar Jul 02 '19 23:07 mayeaux

@dougwilson Click the button ;)

lwouis avatar Jul 17 '19 12:07 lwouis

The sort option should apply to all the response types not just the html one.

dougwilson avatar Jul 17 '19 14:07 dougwilson

looks like the Appveyor node 1.8 env flaked out on us 😢

let's see if I can trigger a second test run 🤔

https://ci.appveyor.com/project/dougwilson/serve-index/builds/26065525 Screen Shot 2019-07-18 at 12 51 57 AM

micahstubbs avatar Jul 18 '19 07:07 micahstubbs

🎉 tests are green. should be ready for another look @dougwilson 😄

micahstubbs avatar Jul 18 '19 15:07 micahstubbs