serve-index
serve-index copied to clipboard
expressjs
Append slash on directories
I should have looked at the other PRs... looks like this has come up quite a bit. I guess I should close this in favor of #31
Hi! Have you taken a look at the other two PRs for this yet? Can you comment on the difference between your PR and those?
No worries. It was my bad.
This PR is pretty lacking. I should have looked at json & plain closer.
Are you still looking for: https://github.com/expressjs/serve-index/pull/31#issuecomment-111911163 ? Do you think trailingSlashes should be an option? To match apache & nginx, I personally think that this should be the default.
Katello (Red Hat Satellite) uses this code to crawl a directory listing and find necessary files. I would assume there are probably some other crawlers that work in a similar way.
I can work on unifying #27 & #31 (& now this one). Just let me know which one you are leaning toward.
Thanks!
Awesome. Let me collect my thoughts for you and then when I get home in a bit, I'll write them out :)
As for it being an option, unfortunately we did a while ago try just adding trailing slashes but it broke people. I 100% agree it should be default, but to do that we do need to major bump based on past problems. We are open for a major bump Aug 1 if you want to wait, otherwise we can add it as optional now and swap the default on the Aug 1 major.