multer icon indicating copy to clipboard operation
multer copied to clipboard

Handle gzip encoding

Open wenjunche opened this issue 3 years ago • 5 comments

wenjunche avatar Jan 21 '21 14:01 wenjunche

@LinusU any chance to merge this in?

dko-slapdash avatar Mar 05 '21 01:03 dko-slapdash

Sorry for not getting to this earlier 🙈

What issue is this addressing? Is this in line with how other platforms handle theses requests? Is this inline with web standards for form data handling?

Would love some background, and to understand specifically what problem this solves, before merging this...

LinusU avatar Sep 08 '21 18:09 LinusU

Sorry for not getting to this earlier 🙈

What issue is this addressing? Is this in line with how other platforms handle theses requests? Is this inline with web standards for form data handling?

Would love some background, and to understand specifically what problem this solves, before merging this...

wenjunche avatar Sep 09 '21 15:09 wenjunche

sorry. closed it by accident.

This PR is addressing cases of uploaded contents in gzip format. My change is based on https://github.com/mscdex/busboy/issues/150.

wenjunche avatar Sep 09 '21 16:09 wenjunche

This PR is addressing cases of uploaded contents in gzip format

I understand this, but I still don't understand when that would happen. As I said, I would love some background to understand what we are fixing here 😅

That being said, I think that this would be best submitted as a pull request to the newly created fork of Busboy, which we are switching to:

https://github.com/fastify/busboy

LinusU avatar Dec 07 '21 11:12 LinusU