allow file upload without filename

Open warncke opened this issue 7 years ago • 2 comments

This is an edge case where a client is sending an upload request without a filename but with the content type of application/octet-stream so it gets silently ignored.

Per the spec filename is not required (https://tools.ietf.org/html/rfc1867) so even if this is a rare case it seems reasonable to allow.

Dec 07 '18 09:12 warncke

Hmmm, do you think that this should be a breaking change? 🤔

I'm guessing yes maybe? 🤔

Dec 13 '18 16:12 LinusU

i don't have a good answer on this. it does change the behavior significantly, but it applies to a very narrow set of cases, and it makes the behavior more consistent with the specs, so not sure how you classify it.

at the end of the day i don't think many people are encountering this issue or it would have been raised before so probably best to err on the side of caution and not breaking anything for existing users.

Dec 13 '18 16:12 warncke